Add a compatibility package to allow registering legacy wallet adapters as standard wallets #42
Conversation
…rs as standard wallets
There was a problem hiding this comment.
Thanks for this! I'll stop here with the feedback, and take another pass if you have the time to roll in some of the feedback.
The only other meta piece of feedback I have to offer (without actually having inspected the situation too closely) is that there's a lot of ! assertions everywhere. The target number of ! assertions, on the internet, should be zero. I have to believe that there's either something we can do to eliminate those, or worse that the presence of those is burying a bug.
|
@steveluscher thanks for the feedback!
Not really sure why I added all the ! assertions since they're not even doing anything (type-wise) seeing that Array[number] doesn't return |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This is an example implementation of an
Adapterwrapper that conforms toWallet. This allows registering anyAdapterfrom@solana/wallet-adapter-walletsin a@wallet-standard/baseWallet.This is potentially useful in the following scenarios:
@solana/wallet-adapter-reactto@wallet-standard/<>packages since there is no dependency on adapters to upgrade their code.@wallet-standardby just registering the adapter wrapper on demand (for example right before the user wants to connect). The implementation for this would need to provide name + icon since they are then no longer available from the wrapper (since it is not loaded yet).This PR merely serves as an example. There at least a few kinks that need to be worked out as well as some testing before there can be any talk about proceeding with this.
cc @jordaaash @steveluscher